From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] fm10k: fix wrong Rx func is used Date: Fri, 27 Nov 2015 19:50:17 +0100 Message-ID: <1697422.A7HKKzriin@xps13> References: <1448589345-16239-1-git-send-email-jing.d.chen@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Chen Jing D(Mark)" Return-path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 678FA58C3 for ; Fri, 27 Nov 2015 19:51:37 +0100 (CET) Received: by wmww144 with SMTP id w144so67991166wmw.0 for ; Fri, 27 Nov 2015 10:51:37 -0800 (PST) In-Reply-To: <1448589345-16239-1-git-send-email-jing.d.chen@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-11-27 09:55, Chen Jing D: > From: "Chen Jing D(Mark)" > > Steps to reproduce the bug: > 1. All Rx offloading is disabled and start the device, then > Vector Rx is used. > 2. Stop the device. Re-configure to enable hw_ip_checksum = 1, > start the device again. > 3. In this case, assume regular Rx should be used since Vector > Rx doesn't support ip checksum offload. But actually Vector > Rx is used and cause checksum won't be done by hardware. > > The reason is after re-configuring, driver misses an "else" in > func fm10k_set_rx_function(). Then Rx func in last round are > used. > > Fixes:77a8ab47("fm10k: select best Rx function") git log -1 --abbrev=12 --format='Fixes: %h ("%s")' 77a8ab47 Fixes: 77a8ab47eb38 ("fm10k: select best Rx function") > Reported-by: Xiao Wang > Signed-off-by: Chen Jing D(Mark) Acked-by: Xiao Wang Applied, thanks