From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 1/2] Fix CPU and memory parameters on IBM POWER8 Date: Wed, 30 Mar 2016 12:52:52 +0200 Message-ID: <1697595.mIzdCROXzL@xps13> References: <1458893513-22406-1-git-send-email-chaozhu@linux.vnet.ibm.com> <1458893513-22406-2-git-send-email-chaozhu@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, David Marchand , "Richardson, Bruce" , Panu Matilainen To: Chao Zhu Return-path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 1010D2C05 for ; Wed, 30 Mar 2016 12:54:45 +0200 (CEST) Received: by mail-wm0-f49.google.com with SMTP id 127so92222497wmu.1 for ; Wed, 30 Mar 2016 03:54:45 -0700 (PDT) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-03-25 09:48, David Marchand: > On Fri, Mar 25, 2016 at 9:11 AM, Chao Zhu wrote: > > This patch fixes the max logic number and memory channel number settings > > on IBM POWER8 platform. > > 1. The max number of logic cores of a POWER8 processor is 96. Normally, > > there are two sockets on a server. So the max number of logic cores > > are 192. So this parch set CONFIG_RTE_MAX_LCORE to 256. > > This is a power8 configuration item, this should go to power8 config > file, not common_base. > > > 2. Currently, the max number of memory channels are hardcoded to 4. However, > > on a POWER8 machine, the max number of memory channels are 8. To fix this, > > CONFIG_RTE_MAX_NCHANNELS is added to do the configuration. > > I don't see any reason why we would need a max value for force_nchannel. > We should just get rid of this check, this is an obscure parameter for > most people, so people playing with it know what they are doing > (hopefully ?). > > On the other hand, if power8 has some specifics about it, maybe we > should introduce some default value in a arch eal header for other > dpdk components to use (like in mempool). > Thoughts ? Chao? We are running out of time for 16.04.