From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 2/3] librte_eal: Import FreeBSD sys/tree.h into librte_eal/common Date: Thu, 09 Jun 2016 17:14:38 +0200 Message-ID: <1698071.MQjfzqW9Q9@xps13> References: <1465433634-6667-1-git-send-email-nikita@elyzion.net> <20160608175848.28bff0d1@xeon-e3> <867a1095-3df7-0278-90b7-aa852764a566@elyzion.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Stephen Hemminger , Takuya ASADA , Takuya ASADA To: Nikita Kozlov Return-path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 924621DB1 for ; Thu, 9 Jun 2016 17:14:40 +0200 (CEST) Received: by mail-wm0-f43.google.com with SMTP id k204so65105840wmk.0 for ; Thu, 09 Jun 2016 08:14:40 -0700 (PDT) In-Reply-To: <867a1095-3df7-0278-90b7-aa852764a566@elyzion.net> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-06-09 16:54, Nikita Kozlov: > On 06/ 9/16 02:58 AM, Stephen Hemminger wrote: > > Please don't copy a header file which is available already on both BSD and Linux. > > > I was quite hesitant on how to handle it. I had the feeling that dpdk > wanted to avoid external dependency so I copied that file. If it's not > the case I would be happy to resend the patches without that external > import. Yes please let's use external libraries where possible. Being able to run in a bare metal environment has been a requirement in the early days of DPDK. Now we got rid of this idea and run on Linux and FreeBSD. An attempt to run on OSv has been done but without more follow-up.