From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v8 11/12] eal: Consolidate
	pci_map/unmap_device() of linuxapp and bsdapp
Date: Wed, 08 Jul 2015 10:27:42 +0200
Message-ID: <1698963.eCjHRZebdj@xps13>
References: <1435652668-3380-12-git-send-email-mukawa@igel.co.jp>
 <CALwxeUse35k41OfLg+rX3CYcOT9guNv+mYgEBrkm=jC-=BKxnQ@mail.gmail.com>
 <559C8E32.3070808@igel.co.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Tetsuya Mukawa <mukawa@igel.co.jp>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com
 [209.85.212.170]) by dpdk.org (Postfix) with ESMTP id 37CB72A5E
 for <dev@dpdk.org>; Wed,  8 Jul 2015 10:28:53 +0200 (CEST)
Received: by wifm2 with SMTP id m2so81891645wif.1
 for <dev@dpdk.org>; Wed, 08 Jul 2015 01:28:53 -0700 (PDT)
In-Reply-To: <559C8E32.3070808@igel.co.jp>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-07-08 11:42, Tetsuya Mukawa:
> On 2015/07/07 17:06, David Marchand wrote:
> > On Mon, Jul 6, 2015 at 8:24 AM, Tetsuya Mukawa <mukawa@igel.co.jp
> >     +       /* FreeBSD has only one pass through driver */
> >     +       dev->kdrv = RTE_KDRV_NIC_UIO;
> >     +
> >
> > Do we need a new define for this ?
> >
> > I know this is not really part of this patchset, but this kdrv should
> > just disappear.
> 
> Do you mean kdrv member will disappear in next DPDK release?

No, it is not (yet) planned to be removed.
But David thinks it shouldn't be part of the public API.
So, as David said, this comment is not really related to your patch.
It may be addressed separately.
Please Tetsuya, go ahead with the v9.
Thanks