From mboxrd@z Thu Jan  1 00:00:00 1970
From: Akhil Goyal <akhil.goyal@nxp.com>
Subject: Re: [PATCH v5 08/11] mk: add rte security into build
	system
Date: Wed, 25 Oct 2017 16:42:33 +0530
Message-ID: <16fa1bbe-4981-efe1-085d-ece06d7cfeda@nxp.com>
References: <20171014221734.15511-1-akhil.goyal@nxp.com>
 <20171024141545.30837-1-akhil.goyal@nxp.com>
 <20171024141545.30837-9-akhil.goyal@nxp.com> <2265201.zheMNP9zCB@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>, <declan.doherty@intel.com>,
 <pablo.de.lara.guarch@intel.com>, <hemant.agrawal@nxp.com>,
 <radu.nicolau@intel.com>, <borisp@mellanox.com>, <aviadye@mellanox.com>,
 <sandeep.malik@nxp.com>, <jerin.jacob@caviumnetworks.com>,
 <john.mcnamara@intel.com>, <konstantin.ananyev@intel.com>,
 <shahafs@mellanox.com>, <olivier.matz@6wind.com>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam02on0056.outbound.protection.outlook.com [104.47.36.56])
 by dpdk.org (Postfix) with ESMTP id 162E01B1C7
 for <dev@dpdk.org>; Wed, 25 Oct 2017 13:12:41 +0200 (CEST)
In-Reply-To: <2265201.zheMNP9zCB@xps>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Thomas,
On 10/25/2017 2:18 AM, Thomas Monjalon wrote:
> Can you squash this patch with the one bringing the lib?
Ok will do that. Will need to move the cryptodev/mbuf/ethdev/net patches 
before the library patch.

> 
>> +DEPDIRS-librte_cryptodev += librte_ether
> 
> I don't like this dependency.
> Why is it needed?

It will be removed in v6.
We no longer need it. It was used in some previous versions of this 
series. It accidentally got missed. Thanks for pointing this out.
> 
>> +DIRS-$(CONFIG_RTE_LIBRTE_SECURITY) += librte_security
>> +DEPDIRS-librte_security := librte_eal librte_mempool librte_ring librte_mbuf
>> +DEPDIRS-librte_security += librte_ether
>> +DEPDIRS-librte_security += librte_cryptodev
> 
> 

-Akhil