From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 1/2] eal: add new rte color definition Date: Mon, 17 Dec 2018 21:35:19 +0100 Message-ID: <1704422.YVeuKdbJKR@xps> References: <1544193116-7058-1-git-send-email-reshma.pattan@intel.com> <20181213180851.4862-1-reshma.pattan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com, nikhil.rao@intel.com, jasvinder.singh@intel.com, cristian.dumitrescu@intel.com, ferruh.yigit@intel.com, arybchenko@solarflare.com To: Reshma Pattan Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 215635587 for ; Mon, 17 Dec 2018 21:35:27 +0100 (CET) In-Reply-To: <20181213180851.4862-1-reshma.pattan@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 13/12/2018 19:08, Reshma Pattan: > Added new rte_color definition in eal to > consolidate color definition which is currently replicated > in various places such as rte_meter.h, rte_tm.h and rte_mtr.h I don't think EAL is the right place for such definition. Why ethdev would not rely on definitions from rte_meter.h?