From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] service: fix memory leak by rte_service_init Date: Thu, 25 Jan 2018 23:10:57 +0100 Message-ID: <1706116.QiZev3mjbx@xps> References: <1514731568-3979-1-git-send-email-vipin.varghese@intel.com> <1515694853-7949-1-git-send-email-vipin.varghese@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, harry.van.haaren@intel.com, bruce.richardson@intel.com To: Vipin Varghese Return-path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 8747A1B1BA for ; Thu, 25 Jan 2018 23:11:48 +0100 (CET) In-Reply-To: <1515694853-7949-1-git-send-email-vipin.varghese@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 11/01/2018 19:20, Vipin Varghese: > This patch fixes the memory leak created by rte_service_init. When > secondary application which shares the huge page from primary, is > executed multiple times memory is initialized but not freed on exit > > The rte_service_finalize checks if the service is initialized. If yes, > it frees up rte_services & lcore_states. The API has to be called at > end of application run. > > renamed the function from rte_service_deinit to rte_service_finalize. This is a changelog. It should appear below --- > Signed-off-by: Vipin Varghese Why not keeping previous ack? Your patches have been set to "Not Applicable" in patchwork. What happened?