From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v10 0/4] examples: add performance-thread Date: Fri, 11 Dec 2015 12:42:50 +0100 Message-ID: <1708049.N2o5aAuiY6@xps13> References: <1449511120-16899-git-send-email-ian.betts@intel.com> <2675420.lydU3fXaQs@xps13> <877C1F8553E92F43898365570816082F35C0CEA6@IRSMSX103.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Betts, Ian" Return-path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id E668E8E7A for ; Fri, 11 Dec 2015 12:44:06 +0100 (CET) Received: by mail-wm0-f45.google.com with SMTP id l68so9486815wml.0 for ; Fri, 11 Dec 2015 03:44:06 -0800 (PST) In-Reply-To: <877C1F8553E92F43898365570816082F35C0CEA6@IRSMSX103.ger.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-12-11 08:31, Betts, Ian: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > >Applied, thanks > >The patch to mark it experimental and disable it has also been applied. > >The huge codebase has been integrated to give visibility. > >We need to discuss it more and decide how to continue (as a lib or drop). > > Thanks Thomas, > When you analyze the "huge" codebase it breaks into 3 parts: > > 1. A common l-thread subsystem ( ~2Kloc ) > 2. An l3fwd derived example ( ~2Kloc) > 3. An hello world example pthread shim ( ~700loc ) > > If there is interest in lightweight threads the hope/expectation is that the l-thread > subsystem would become an rte library. On the scale of things I would describe > it as an average sized lib in DPDK terms. Yes, if it gains some interest and fit in the desired scope of DPDK, it may become a library. > As for the examples, obviously there needs to be some example, but perhaps > it is not so critical if they are retained in the present form, at least this is the only > place I can see to save lines of code. Yes. Maybe we can make some efforts to shrink the size of examples (generally) to make them easy to maintain and didactic.