From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v3 3/3] doc: update build-sdk-quick txt file
Date: Wed, 14 Feb 2018 00:41:03 +0100
Message-ID: <1709610.YWM5RO7iyE@xps>
References: <1495788764-37652-2-git-send-email-david.hunt@intel.com>
 <B27915DBBA3421428155699D51E4CFE23ECEF26C@IRSMSX104.ger.corp.intel.com>
 <b150032a-c7d9-9b94-8b67-5d2022655a3c@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "shreyansh.jain@nxp.com" <shreyansh.jain@nxp.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, "Mcnamara,
 John" <john.mcnamara@intel.com>, "Hunt, David" <david.hunt@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id F22571B313
 for <dev@dpdk.org>; Wed, 14 Feb 2018 00:41:13 +0100 (CET)
In-Reply-To: <b150032a-c7d9-9b94-8b67-5d2022655a3c@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

13/02/2018 13:18, Ferruh Yigit:
> On 6/12/2017 1:50 PM, Mcnamara, John wrote:
> >> -----Original Message-----
> >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Hunt
> >> Sent: Wednesday, June 7, 2017 3:38 PM
> >> To: dev@dpdk.org
> >> Cc: thomas@monjalon.net; shreyansh.jain@nxp.com; Hunt, David
> >> <david.hunt@intel.com>
> >> Subject: [dpdk-dev] [PATCH v3 3/3] doc: update build-sdk-quick txt file
> >>
> >>   * Add in information about 'make defconfig'
> >>   * Add in information about RTE_TEMPLATE environment variable
> >>   * Explain the default directory for 'O=' a bit better
> >>   * Clean up text alignment
> >>
> >> Signed-off-by: David Hunt <david.hunt@intel.com>
> > 
> > Acked-by: John McNamara <john.mcnamara@intel.com>
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

I made some comments in patch 2 about RTE_TEMPLATE and got no reply
(in August).

This patch is dependent on RTE_TEMPLATE.

One more nit: the indent is broken for T variable explanation.