From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v3 2/6] ethdev: add iterator to match devargs
	input
Date: Tue, 09 Oct 2018 16:17:14 +0200
Message-ID: <1710140.5mMnjyfntK@xps>
References: <20181007222554.4886-1-thomas@monjalon.net>
 <20181009133450.19112-1-thomas@monjalon.net>
 <20181009133450.19112-3-thomas@monjalon.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: gaetan.rivet@6wind.com, ophirmu@mellanox.com, ferruh.yigit@intel.com,
 arybchenko@solarflare.com
To: dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id BEEE61B534
 for <dev@dpdk.org>; Tue,  9 Oct 2018 16:17:17 +0200 (CEST)
In-Reply-To: <20181009133450.19112-3-thomas@monjalon.net>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

09/10/2018 15:34, Thomas Monjalon:
> +int __rte_experimental
> +rte_eth_iterator_init(struct rte_dev_iterator *iter, const char *devargs_str)
> +{
> +       int ret;
> +       struct rte_devargs devargs = {.args = NULL};
> +       const char *bus_param_key;
> +       char *bus_str = NULL;
> +       char *cls_str = NULL;
> +       size_t str_size;

Because of the new test below, the type must be fixed to int.

[...]
> +       ret = snprintf(cls_str, str_size, "+%s", devargs.args);
> +       if (ret != str_size - 1) {
> +               ret = -EINVAL;
> +               goto error;
> +       }