From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2B5CC54E8E for ; Mon, 11 May 2020 16:39:30 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 3E20D20714 for ; Mon, 11 May 2020 16:39:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="bgdsFYmp"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="jltTZHtc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E20D20714 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 939E81C1C3; Mon, 11 May 2020 18:39:29 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 8FB0D1C1BB; Mon, 11 May 2020 18:39:27 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 7B6515F2; Mon, 11 May 2020 12:39:26 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Mon, 11 May 2020 12:39:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= cu0iRElOKY5b2b6Iwy7yrX2TJkZfVUnudkaQgHKqvb0=; b=bgdsFYmpdFKwNf9s P6iiFJaYq+mwgrTzEBLq6BVVmObCWMbooI1KI0LzCmyzhujRH3kq2LaDKFN99agx d4gLaxoqbVbCXrOf+Gnguk3jSrmXy6l0X+VfPOIxb8Y8GCyNjV46nfLOyxf3WKIK BJPhq2jpGV3wAaAqYoiaYLUjqMNQ6zIJmzdxe75i12kaspvQaVcMfQEHZi2nZBPx /QR/rrE0Qy7noQsYP+vQgqdhCMTLWvQii/QfedZ5WxCQOZPcTUwKp2fZ39F6DSEJ 5sz30j1y+c78C4KKpoJH/8WqipQbpu4Vgq+3xaMeZhye6BIWZ4OfdNMz5CwYk2DZ dNxGEQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=cu0iRElOKY5b2b6Iwy7yrX2TJkZfVUnudkaQgHKqv b0=; b=jltTZHtcMZg/bOOZE2RJeRFfwo70voeoKhHkRhyUNZgJ28I2Slvshjux6 tIx5bfmEdxOu7hKz6XxKC8z1b4z2iwxC0owDMpdbN+7VUP/uXClN4TmiRCgYjbft 0bcD6B3TzknOyBCuea1fAnQgCSJXZp7/m8EHUNQW6iMBesEJ1V+f5ufBaOuRd4KN YvKDiI6OvZeAOTPboix4X9IxU/HgOmK2RR7z2owhVH4PhxL7xUsxXxoxlKUSo/uQ 2lUyJB6G6eklmWzCzjm3YMh3yEHUXvVoCxVYaqLc86b05d3t9cn2y4DxMy/SVwJq zrHbeC/ncFPb+1fjEgqsd8xDAh2Iw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrledtgdeljecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2337F306627C; Mon, 11 May 2020 12:39:22 -0400 (EDT) From: Thomas Monjalon To: "Van Haaren, Harry" Cc: "dev@dpdk.org" , stable@dpdk.org, "pbhagavatula@caviumnetworks.com" , "Zhou, JunX W" Date: Mon, 11 May 2020 18:39:21 +0200 Message-ID: <1711809.BzM5BlMlMQ@thomas> In-Reply-To: References: <20200505093904.20616-1-harry.van.haaren@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] examples/eventdev_pipeline: fix segfault on exit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 07/05/2020 12:07, Zhou, JunX W: > From: Van Haaren, Harry > > This commit fixes a segfault on exit by using Ctrl^C if the master lcore > > was also being used as a worker core. The root cause of the issue was > > that the interrupt handler was cleaning up resources such as the ethdev > > and eventdev ports, and once the interrupt handler would return, that > > thread would continue working as an eventdev worker, and dereference the > > memory which just had free() called on it. > > > > Fixed by moving the cleanup code from the interrupt handler to the cleanup > > stage of main(), which the master thread will execute once it has > > returned from its worker() functionality. > > > > Fixes: 085edac2ca38 ("examples/eventdev_pipeline: support Tx adapter") > > > > Signed-off-by: Harry van Haaren > Tested-by: Zhou, JunX W Applied, thanks