From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v3 5/6] Move common functions in eal_timer.c
Date: Mon, 05 Jan 2015 22:09:23 +0100
Message-ID: <1714110.hG7iXKm2FP@xps13>
References: <1419957384-11693-1-git-send-email-rkerur@gmail.com>
 <1419957440-11767-1-git-send-email-rkerur@gmail.com>
 <1419957440-11767-5-git-send-email-rkerur@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Ravi Kerur <rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <1419957440-11767-5-git-send-email-rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

2014-12-30 11:37, Ravi Kerur:
> Use common function name set_tsc_freq_from_sysctl for BSD and Linux.

[...]

> +/**
> + * This function sets TSC frequency from sysctl
> + * for BSD and from clock for Linux.
> + *
> + * This function is private to the EAL.
> + */
> +int set_tsc_freq_from_sysctl(void);

[...]

> -static int
> -set_tsc_freq_from_clock(void)
> +int
> +set_tsc_freq_from_sysctl(void)

NACK
It doesn't seem reasonnable to call a function set_tsc_freq_from_sysctl()
if it doesn't use sysctl.

-- 
Thomas