From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 4/4] eal: fix end character check in --lcores argument Date: Thu, 28 Jul 2016 18:05:51 +0200 Message-ID: <1717702.2SVR8RdYDI@xps13> References: <1469081018-55300-1-git-send-email-wei.dai@intel.com> <1469618870-144592-1-git-send-email-wei.dai@intel.com> <579A2433.1060701@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Ferruh Yigit To: Wei Dai Return-path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 5F3F43237 for ; Thu, 28 Jul 2016 18:05:53 +0200 (CEST) Received: by mail-wm0-f54.google.com with SMTP id o80so115178514wme.1 for ; Thu, 28 Jul 2016 09:05:53 -0700 (PDT) In-Reply-To: <579A2433.1060701@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-07-28 16:26, Ferruh Yigit: > On 7/27/2016 12:27 PM, Wei Dai wrote: > > With --lcores 'a-b@c-d', eal_parse_cores() fails because > > eal_parse_set() fails due to the next character after > > lcore set a-b, which is '@'and not ',' or '\0'. > > There is also a right check immediately > > after this incorrect check. > > > > Fixes: 53e54bf81700 ("eal: new option --lcores for cpu assignment") > > > > Signed-off-by: Wei Dai > > I am not sure if a-b@c-d syntax should be supported. (a-b)@(c-d) is > supported and already working. Agreed. Series applied, except this last patch 4, thanks