From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs Date: Fri, 05 Jun 2015 23:03:44 +0200 Message-ID: <1719417.vraBA1o1Y8@xps13> References: <1432927612-12244-1-git-send-email-liang-min.wang@intel.com> <20150605124748.GA6760@bricha3-MOBL3> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "Wang, Liang-min" To: "Andrew Harvey (agh)" Return-path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id 06460C348 for ; Fri, 5 Jun 2015 23:04:39 +0200 (CEST) Received: by wiwd19 with SMTP id d19so32615985wiw.0 for ; Fri, 05 Jun 2015 14:04:38 -0700 (PDT) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-06-05 17:24, Andrew Harvey: > On 6/5/15, 5:47 AM, "Bruce Richardson" wrote: > >> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > >> > That's why we need to understand what we (or you) are missing. > >> > Maybe that it would be clearer with some code examples (which would > >> > go in the lib documentation if any). > >> > > >> > Thanks > > > >How about doing this work as a sample application initially, to > >demonstrate how > >an application written using ethtool APIs could be shimmed to use DPDK > >underneath. > >The ethtool to dpdk mapping could be contained in a single header file > >(or header > >and c file) inside the sample app. This would allow easy re-use of the > >shim > >layer, while at the same time not making it part of the core DPDK > >libraries. > > > >Regards, > >/Bruce > > This would appear to be the most pragmatic way forward. It would allow > others to see more of the code and judge its value for themselves. I have > no issues with this approach if others agree. Since the beginning of this thread, a doc is requested (many times) to show the benefit of integrating such a layer. If you prefer coding a full example, it would probably also be fine.