From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory Etelson Subject: Re: [PATCH v2] igb_uio: issue FLR during open and release of device file Date: Wed, 19 Jul 2017 19:19:05 +0300 Message-ID: <1723914.rl5aSUidYg@polaris> References: <1497260285-27536-1-git-send-email-shijith.thotton@caviumnetworks.com> <43fc4f53-404d-242b-4a6e-508966b236af@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: "Tan, Jianfeng" , Shijith Thotton , "dev@dpdk.org" , Thomas Monjalon , Stephen Hemminger , "Lu, Wenzhuo" To: Ferruh Yigit Return-path: Received: from mail-wr0-f174.google.com (mail-wr0-f174.google.com [209.85.128.174]) by dpdk.org (Postfix) with ESMTP id 0171E2030 for ; Wed, 19 Jul 2017 18:19:08 +0200 (CEST) Received: by mail-wr0-f174.google.com with SMTP id k71so7199758wrc.2 for ; Wed, 19 Jul 2017 09:19:08 -0700 (PDT) In-Reply-To: <43fc4f53-404d-242b-4a6e-508966b236af@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wednesday, 19 July 2017 16:32:34 IDT Ferruh Yigit wrote: > On 7/12/2017 4:40 AM, Tan, Jianfeng wrote: > > > > > >> -----Original Message----- > >> From: Shijith Thotton [mailto:shijith.thotton@caviumnetworks.com] > >> Sent: Friday, July 7, 2017 7:14 PM > >> To: dev@dpdk.org > >> Cc: Yigit, Ferruh; Gregory Etelson; Thomas Monjalon; Stephen Hemminger; > >> Tan, Jianfeng; Lu, Wenzhuo > >> Subject: [PATCH v2] igb_uio: issue FLR during open and release of device file > >> > >> Set UIO info device file operations open and release. Call pci reset > >> function inside open and release to clear device state at start and end. > >> Copied this behaviour from vfio_pci kernel module code. With this patch, > >> it is not mandatory to issue FLR by PMD's during init and close. > >> > >> Bus master enable and disable are added in open and release respectively > >> to take care of device DMA. > >> > >> Signed-off-by: Shijith Thotton > > > > Reviewed-by: Jianfeng Tan > > Acked-by: Ferruh Yigit > Acked-by: Gregory Etelson