From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v2] cryptodev: uninline parameter parsing
Date: Sun, 26 Jun 2016 18:31:57 +0200
Message-ID: <1724516.iAvns5DDEp@xps13>
References: <1466783244-4484-1-git-send-email-thomas.monjalon@6wind.com>
 <1466860424-4155-1-git-send-email-thomas.monjalon@6wind.com>
 <E115CCD9D858EF4F90C690B0DCB4D8973C96A09B@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: "Doherty, Declan" <declan.doherty@intel.com>, dev@dpdk.org
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51])
 by dpdk.org (Postfix) with ESMTP id 080B65ABB
 for <dev@dpdk.org>; Sun, 26 Jun 2016 18:32:00 +0200 (CEST)
Received: by mail-wm0-f51.google.com with SMTP id v199so73419311wmv.0
 for <dev@dpdk.org>; Sun, 26 Jun 2016 09:32:00 -0700 (PDT)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8973C96A09B@IRSMSX108.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-06-25 15:24, De Lara Guarch, Pablo:
> > +DPDK_16.07 {
> > +	global:
> > +
> > +	rte_cryptodev_parse_vdev_init_params;
> 
> I think this function does not need to be public.
> This function is only called in the PMDs, and the only public function
> to initialize a crypto device is rte_eal_vdev_init.

It needs to be public to be called by the PMDs,
like, example, rte_cryptodev_pmd_virtual_dev_init.

> Also, could you remove the includes of rte_vargs.h in the PMDs,
> as it is not needed (I think it was not necessary before either).

Yes I am going to send a v3 with this change.
Thanks