* [PATCH] test: Disable strict-aliasing warnings
@ 2015-03-26 19:17 Pablo de Lara
2015-03-27 8:41 ` Qiu, Michael
[not found] ` <1427397455-30368-1-git-send-email-pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
0 siblings, 2 replies; 17+ messages in thread
From: Pablo de Lara @ 2015-03-26 19:17 UTC (permalink / raw)
To: dev-VfR2kkLFssw
DPDK does not build on gcc 4.4, as it complains due to
strict-aliasing rules in virtual_pmd and link_bonding_mode4 tests,
with no errors in next gcc versions:
CC virtual_pmd.o
CC test_link_bonding_mode4.o
cc1: warnings being treated as errors
/root/dpdk/app/test/test_link_bonding_mode4.c: In function ‘test_mode4_expired’:
/root/dpdk/x86_64-native-linuxapp-gcc/include/rte_ring.h:645: error: dereferencing pointer ‘pkt.409’ does break strict-aliasing rules
/root/dpdk/x86_64-native-linuxapp-gcc/include/rte_ring.h:729: error: dereferencing pointer ‘pkt.409’ does break strict-aliasing rules
...
cc1: warnings being treated as errors
/root/dpdk/app/test/virtual_pmd.c: In function ‘virtual_ethdev_stats_reset’:
/root/dpdk/x86_64-native-linuxapp-gcc/include/rte_ring.h:645: error: dereferencing pointer ‘pkt.338’ does break strict-aliasing rules
/root/dpdk/x86_64-native-linuxapp-gcc/include/rte_ring.h:729: error: dereferencing pointer ‘pkt.338’ does break strict-aliasing rules
This patch fixes the compilation by disabling
these warnings.
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
app/test/Makefile | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/app/test/Makefile b/app/test/Makefile
index 4aca77c..0d62d07 100644
--- a/app/test/Makefile
+++ b/app/test/Makefile
@@ -158,6 +158,11 @@ CFLAGS_test_memcpy_perf.o += -fno-var-tracking-assignments
endif
endif
+# Disable warnings of no-strict-aliasing in virtual_pmd
+# and test_link_bonding_mode4 tests
+CFLAGS_virtual_pmd.o += -Wno-strict-aliasing
+CFLAGS_test_link_bonding_mode4.o += -Wno-strict-aliasing
+
# this application needs libraries first
DEPDIRS-y += lib
--
1.7.4.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH] test: Disable strict-aliasing warnings
2015-03-26 19:17 [PATCH] test: Disable strict-aliasing warnings Pablo de Lara
@ 2015-03-27 8:41 ` Qiu, Michael
[not found] ` <533710CFB86FA344BFBF2D6802E60286D18E59-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
[not found] ` <1427397455-30368-1-git-send-email-pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
1 sibling, 1 reply; 17+ messages in thread
From: Qiu, Michael @ 2015-03-27 8:41 UTC (permalink / raw)
To: De Lara Guarch, Pablo, dev-VfR2kkLFssw@public.gmane.org
On 3/27/2015 3:18 AM, Pablo de Lara wrote:
> DPDK does not build on gcc 4.4, as it complains due to
Why? Will gcc 4.4 not supported?
Thanks,
Michael
> strict-aliasing rules in virtual_pmd and link_bonding_mode4 tests,
> with no errors in next gcc versions:
>
> CC virtual_pmd.o
> CC test_link_bonding_mode4.o
> cc1: warnings being treated as errors
> /root/dpdk/app/test/test_link_bonding_mode4.c: In function ‘test_mode4_expired’:
> /root/dpdk/x86_64-native-linuxapp-gcc/include/rte_ring.h:645: error: dereferencing pointer ‘pkt.409’ does break strict-aliasing rules
> /root/dpdk/x86_64-native-linuxapp-gcc/include/rte_ring.h:729: error: dereferencing pointer ‘pkt.409’ does break strict-aliasing rules
> ...
> cc1: warnings being treated as errors
> /root/dpdk/app/test/virtual_pmd.c: In function ‘virtual_ethdev_stats_reset’:
> /root/dpdk/x86_64-native-linuxapp-gcc/include/rte_ring.h:645: error: dereferencing pointer ‘pkt.338’ does break strict-aliasing rules
> /root/dpdk/x86_64-native-linuxapp-gcc/include/rte_ring.h:729: error: dereferencing pointer ‘pkt.338’ does break strict-aliasing rules
>
> This patch fixes the compilation by disabling
> these warnings.
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> ---
> app/test/Makefile | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/app/test/Makefile b/app/test/Makefile
> index 4aca77c..0d62d07 100644
> --- a/app/test/Makefile
> +++ b/app/test/Makefile
> @@ -158,6 +158,11 @@ CFLAGS_test_memcpy_perf.o += -fno-var-tracking-assignments
> endif
> endif
>
> +# Disable warnings of no-strict-aliasing in virtual_pmd
> +# and test_link_bonding_mode4 tests
> +CFLAGS_virtual_pmd.o += -Wno-strict-aliasing
> +CFLAGS_test_link_bonding_mode4.o += -Wno-strict-aliasing
> +
> # this application needs libraries first
> DEPDIRS-y += lib
>
^ permalink raw reply [flat|nested] 17+ messages in thread
[parent not found: <1427397455-30368-1-git-send-email-pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH] test: Disable strict-aliasing warnings
[not found] ` <1427397455-30368-1-git-send-email-pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
@ 2015-03-27 9:20 ` Thomas Monjalon
2015-03-27 9:29 ` De Lara Guarch, Pablo
2015-03-27 10:55 ` [PATCH v2 0/2] test: fix strict aliasing rule errors in gcc 4.4 Pawel Wodkowski
` (2 subsequent siblings)
3 siblings, 1 reply; 17+ messages in thread
From: Thomas Monjalon @ 2015-03-27 9:20 UTC (permalink / raw)
To: Pablo de Lara; +Cc: dev-VfR2kkLFssw
2015-03-26 19:17, Pablo de Lara:
> DPDK does not build on gcc 4.4, as it complains due to
> strict-aliasing rules in virtual_pmd and link_bonding_mode4 tests,
> with no errors in next gcc versions:
Do you mean it's not possible to fix it in the code?
You are disabling some checks which may be relevant.
> CC virtual_pmd.o
> CC test_link_bonding_mode4.o
> cc1: warnings being treated as errors
> /root/dpdk/app/test/test_link_bonding_mode4.c: In function ‘test_mode4_expired’:
> /root/dpdk/x86_64-native-linuxapp-gcc/include/rte_ring.h:645: error: dereferencing pointer ‘pkt.409’ does break strict-aliasing rules
> /root/dpdk/x86_64-native-linuxapp-gcc/include/rte_ring.h:729: error: dereferencing pointer ‘pkt.409’ does break strict-aliasing rules
> ...
> cc1: warnings being treated as errors
> /root/dpdk/app/test/virtual_pmd.c: In function ‘virtual_ethdev_stats_reset’:
> /root/dpdk/x86_64-native-linuxapp-gcc/include/rte_ring.h:645: error: dereferencing pointer ‘pkt.338’ does break strict-aliasing rules
> /root/dpdk/x86_64-native-linuxapp-gcc/include/rte_ring.h:729: error: dereferencing pointer ‘pkt.338’ does break strict-aliasing rules
>
> This patch fixes the compilation by disabling
> these warnings.
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> ---
> app/test/Makefile | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/app/test/Makefile b/app/test/Makefile
> index 4aca77c..0d62d07 100644
> --- a/app/test/Makefile
> +++ b/app/test/Makefile
> @@ -158,6 +158,11 @@ CFLAGS_test_memcpy_perf.o += -fno-var-tracking-assignments
> endif
> endif
>
> +# Disable warnings of no-strict-aliasing in virtual_pmd
> +# and test_link_bonding_mode4 tests
> +CFLAGS_virtual_pmd.o += -Wno-strict-aliasing
> +CFLAGS_test_link_bonding_mode4.o += -Wno-strict-aliasing
> +
> # this application needs libraries first
> DEPDIRS-y += lib
>
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] test: Disable strict-aliasing warnings
2015-03-27 9:20 ` Thomas Monjalon
@ 2015-03-27 9:29 ` De Lara Guarch, Pablo
[not found] ` <E115CCD9D858EF4F90C690B0DCB4D8972727CC77-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
0 siblings, 1 reply; 17+ messages in thread
From: De Lara Guarch, Pablo @ 2015-03-27 9:29 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev-VfR2kkLFssw@public.gmane.org
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Friday, March 27, 2015 9:20 AM
> To: De Lara Guarch, Pablo
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] test: Disable strict-aliasing warnings
>
> 2015-03-26 19:17, Pablo de Lara:
> > DPDK does not build on gcc 4.4, as it complains due to
> > strict-aliasing rules in virtual_pmd and link_bonding_mode4 tests,
> > with no errors in next gcc versions:
>
> Do you mean it's not possible to fix it in the code?
> You are disabling some checks which may be relevant.
I mean it is possible to fix, but probably not worth it, considering that
newer gcc versions have no issues (and gcc 4.4 is from 2011).
I have seen that there are other libraries that disable these warnings as well,
so I assumed we could do the same here.
Pablo
>
> > CC virtual_pmd.o
> > CC test_link_bonding_mode4.o
> > cc1: warnings being treated as errors
> > /root/dpdk/app/test/test_link_bonding_mode4.c: In function
> ‘test_mode4_expired’:
> > /root/dpdk/x86_64-native-linuxapp-gcc/include/rte_ring.h:645: error:
> dereferencing pointer ‘pkt.409’ does break strict-aliasing rules
> > /root/dpdk/x86_64-native-linuxapp-gcc/include/rte_ring.h:729: error:
> dereferencing pointer ‘pkt.409’ does break strict-aliasing rules
> > ...
> > cc1: warnings being treated as errors
> > /root/dpdk/app/test/virtual_pmd.c: In function
> ‘virtual_ethdev_stats_reset’:
> > /root/dpdk/x86_64-native-linuxapp-gcc/include/rte_ring.h:645: error:
> dereferencing pointer ‘pkt.338’ does break strict-aliasing rules
> > /root/dpdk/x86_64-native-linuxapp-gcc/include/rte_ring.h:729: error:
> dereferencing pointer ‘pkt.338’ does break strict-aliasing rules
> >
> > This patch fixes the compilation by disabling
> > these warnings.
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > ---
> > app/test/Makefile | 5 +++++
> > 1 files changed, 5 insertions(+), 0 deletions(-)
> >
> > diff --git a/app/test/Makefile b/app/test/Makefile
> > index 4aca77c..0d62d07 100644
> > --- a/app/test/Makefile
> > +++ b/app/test/Makefile
> > @@ -158,6 +158,11 @@ CFLAGS_test_memcpy_perf.o += -fno-var-
> tracking-assignments
> > endif
> > endif
> >
> > +# Disable warnings of no-strict-aliasing in virtual_pmd
> > +# and test_link_bonding_mode4 tests
> > +CFLAGS_virtual_pmd.o += -Wno-strict-aliasing
> > +CFLAGS_test_link_bonding_mode4.o += -Wno-strict-aliasing
> > +
> > # this application needs libraries first
> > DEPDIRS-y += lib
> >
> >
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH v2 0/2] test: fix strict aliasing rule errors in gcc 4.4
[not found] ` <1427397455-30368-1-git-send-email-pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-03-27 9:20 ` Thomas Monjalon
@ 2015-03-27 10:55 ` Pawel Wodkowski
[not found] ` <1427453761-20019-1-git-send-email-pawelx.wodkowski-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-03-27 15:46 ` [PATCH] test: Disable strict-aliasing warnings Stephen Hemminger
2015-03-30 11:06 ` [PATCH v2] DPDK does not build on gcc 4.4, as it complains due to strict-aliasing rules in virtual_pmd and link_bonding_mode4 tests, with no errors in next gcc versions: Pablo de Lara
3 siblings, 1 reply; 17+ messages in thread
From: Pawel Wodkowski @ 2015-03-27 10:55 UTC (permalink / raw)
To: dev-VfR2kkLFssw
Fix strict aliasing rule error seen in gcc 4.4 in virtual pmd and mode 4 link
bonding mode 4 test.
changes v2:
- fix error in code instead disabling compiler warning.
Pawel Wodkowski (2):
test: fix strict aliasing rule error in virtual pmd
test: fix strict aliasing rule error in link bonding mode 4 test
app/test/test_link_bonding_mode4.c | 5 +++--
app/test/virtual_pmd.c | 10 +++++-----
2 files changed, 8 insertions(+), 7 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] test: Disable strict-aliasing warnings
[not found] ` <1427397455-30368-1-git-send-email-pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-03-27 9:20 ` Thomas Monjalon
2015-03-27 10:55 ` [PATCH v2 0/2] test: fix strict aliasing rule errors in gcc 4.4 Pawel Wodkowski
@ 2015-03-27 15:46 ` Stephen Hemminger
2015-03-27 15:48 ` De Lara Guarch, Pablo
2015-03-30 11:06 ` [PATCH v2] DPDK does not build on gcc 4.4, as it complains due to strict-aliasing rules in virtual_pmd and link_bonding_mode4 tests, with no errors in next gcc versions: Pablo de Lara
3 siblings, 1 reply; 17+ messages in thread
From: Stephen Hemminger @ 2015-03-27 15:46 UTC (permalink / raw)
To: Pablo de Lara; +Cc: dev-VfR2kkLFssw
On Thu, 26 Mar 2015 19:17:35 +0000
Pablo de Lara <pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
> +# Disable warnings of no-strict-aliasing in virtual_pmd
> +# and test_link_bonding_mode4 tests
> +CFLAGS_virtual_pmd.o += -Wno-strict-aliasing
> +CFLAGS_test_link_bonding_mode4.o += -Wno-strict-aliasing
> +
>
There is a way to do it only for a specific (broken)
Gcc version using if's
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] test: Disable strict-aliasing warnings
2015-03-27 15:46 ` [PATCH] test: Disable strict-aliasing warnings Stephen Hemminger
@ 2015-03-27 15:48 ` De Lara Guarch, Pablo
0 siblings, 0 replies; 17+ messages in thread
From: De Lara Guarch, Pablo @ 2015-03-27 15:48 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev-VfR2kkLFssw@public.gmane.org
> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org]
> Sent: Friday, March 27, 2015 3:46 PM
> To: De Lara Guarch, Pablo
> Cc: dev-VfR2kkLFssw@public.gmane.org
> Subject: Re: [dpdk-dev] [PATCH] test: Disable strict-aliasing warnings
>
> On Thu, 26 Mar 2015 19:17:35 +0000
> Pablo de Lara <pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
>
> > +# Disable warnings of no-strict-aliasing in virtual_pmd
> > +# and test_link_bonding_mode4 tests
> > +CFLAGS_virtual_pmd.o += -Wno-strict-aliasing
> > +CFLAGS_test_link_bonding_mode4.o += -Wno-strict-aliasing
> > +
> >
>
> There is a way to do it only for a specific (broken)
> Gcc version using if's
I know, I sent another email, saying that I missed an if to check the gcc version.
Anyway, Pawel has sent another patch to fix the issue.
Not sure which fix the community prefers.
Thanks,
Pablo
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH v2] DPDK does not build on gcc 4.4, as it complains due to strict-aliasing rules in virtual_pmd and link_bonding_mode4 tests, with no errors in next gcc versions:
[not found] ` <1427397455-30368-1-git-send-email-pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
` (2 preceding siblings ...)
2015-03-27 15:46 ` [PATCH] test: Disable strict-aliasing warnings Stephen Hemminger
@ 2015-03-30 11:06 ` Pablo de Lara
[not found] ` <1427713576-31094-1-git-send-email-pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
3 siblings, 1 reply; 17+ messages in thread
From: Pablo de Lara @ 2015-03-30 11:06 UTC (permalink / raw)
To: dev-VfR2kkLFssw
CC virtual_pmd.o
CC test_link_bonding_mode4.o
cc1: warnings being treated as errors
/root/dpdk/app/test/test_link_bonding_mode4.c: In function ‘test_mode4_expired’:
/root/dpdk/x86_64-native-linuxapp-gcc/include/rte_ring.h:645: error: dereferencing pointer ‘pkt.409’ does break strict-aliasing rules
/root/dpdk/x86_64-native-linuxapp-gcc/include/rte_ring.h:729: error: dereferencing pointer ‘pkt.409’ does break strict-aliasing rules
...
cc1: warnings being treated as errors
/root/dpdk/app/test/virtual_pmd.c: In function ‘virtual_ethdev_stats_reset’:
/root/dpdk/x86_64-native-linuxapp-gcc/include/rte_ring.h:645: error: dereferencing pointer ‘pkt.338’ does break strict-aliasing rules
/root/dpdk/x86_64-native-linuxapp-gcc/include/rte_ring.h:729: error: dereferencing pointer ‘pkt.338’ does break strict-aliasing rules
This patch fixes the compilation by disabling
these warnings.
Changes in v2:
Added missing gcc version check (checking if gcc 4.4 is present)
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
app/test/Makefile | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/app/test/Makefile b/app/test/Makefile
index 4aca77c..9639a71 100644
--- a/app/test/Makefile
+++ b/app/test/Makefile
@@ -158,6 +158,15 @@ CFLAGS_test_memcpy_perf.o += -fno-var-tracking-assignments
endif
endif
+# Disable warnings of no-strict-aliasing in virtual_pmd
+# and test_link_bonding_mode4 tests
+ifeq ($(CC), gcc)
+ifeq ($(shell test $(GCC_VERSION) -eq 44 && echo 1), 1)
+CFLAGS_virtual_pmd.o += -Wno-strict-aliasing
+CFLAGS_test_link_bonding_mode4.o += -Wno-strict-aliasing
+endif
+endif
+
# this application needs libraries first
DEPDIRS-y += lib
--
1.7.4.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
end of thread, other threads:[~2015-03-30 20:48 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-26 19:17 [PATCH] test: Disable strict-aliasing warnings Pablo de Lara
2015-03-27 8:41 ` Qiu, Michael
[not found] ` <533710CFB86FA344BFBF2D6802E60286D18E59-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-03-27 8:57 ` De Lara Guarch, Pablo
[not found] ` <1427397455-30368-1-git-send-email-pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-03-27 9:20 ` Thomas Monjalon
2015-03-27 9:29 ` De Lara Guarch, Pablo
[not found] ` <E115CCD9D858EF4F90C690B0DCB4D8972727CC77-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-03-27 10:00 ` Thomas Monjalon
2015-03-27 10:11 ` De Lara Guarch, Pablo
[not found] ` <E115CCD9D858EF4F90C690B0DCB4D8972727CCE9-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-03-30 11:11 ` De Lara Guarch, Pablo
2015-03-27 10:55 ` [PATCH v2 0/2] test: fix strict aliasing rule errors in gcc 4.4 Pawel Wodkowski
[not found] ` <1427453761-20019-1-git-send-email-pawelx.wodkowski-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-03-27 10:56 ` [PATCH v2 1/2] test: fix strict aliasing rule error in virtual pmd Pawel Wodkowski
[not found] ` <1427453761-20019-2-git-send-email-pawelx.wodkowski-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-03-27 15:47 ` Stephen Hemminger
2015-03-27 10:56 ` [PATCH v2 2/2] test: fix strict aliasing rule error in link bonding mode 4 test Pawel Wodkowski
2015-03-30 20:48 ` [PATCH v2 0/2] test: fix strict aliasing rule errors in gcc 4.4 Thomas Monjalon
2015-03-27 15:46 ` [PATCH] test: Disable strict-aliasing warnings Stephen Hemminger
2015-03-27 15:48 ` De Lara Guarch, Pablo
2015-03-30 11:06 ` [PATCH v2] DPDK does not build on gcc 4.4, as it complains due to strict-aliasing rules in virtual_pmd and link_bonding_mode4 tests, with no errors in next gcc versions: Pablo de Lara
[not found] ` <1427713576-31094-1-git-send-email-pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-03-30 20:47 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).