From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3] vhost: Fix default value of kickfd and callfd Date: Tue, 15 Mar 2016 00:19:25 +0100 Message-ID: <1728165.aRGmEK0DRC@xps13> References: <1457593565-16240-1-git-send-email-mukawa@igel.co.jp> <1457945612-30165-1-git-send-email-mukawa@igel.co.jp> <20160314091259.GN979@yliu-dev.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Yuanhan Liu , jianfeng.tan@intel.com, huawei.xie@intel.com To: Tetsuya Mukawa Return-path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 8B15347CE for ; Tue, 15 Mar 2016 00:20:49 +0100 (CET) Received: by mail-wm0-f45.google.com with SMTP id l68so3574329wml.1 for ; Mon, 14 Mar 2016 16:20:49 -0700 (PDT) In-Reply-To: <20160314091259.GN979@yliu-dev.sh.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-03-14 17:12, Yuanhan Liu: > On Mon, Mar 14, 2016 at 05:53:32PM +0900, Tetsuya Mukawa wrote: > > Currently, default values of kickfd and callfd are -1. > > If the values are -1, current code guesses kickfd and callfd haven't > > been initialized yet. Then vhost library will guess the virtqueue isn't > > ready for processing. > > But callfd and kickfd will be set as -1 when "--enable-kvm" > > isn't specified in QEMU command line. It means we cannot treat -1 as > > uninitialized state. > > The patch defines -1 and -2 as VIRTIO_INVALID_EVENTFD and > > VIRTIO_UNINITIALIZED_EVENTFD, and uses VIRTIO_UNINITIALIZED_EVENTFD for > > the default values of kickfd and callfd. > > Don't be mean to put an empty line between paragraphs :) > > > Signed-off-by: Tetsuya Mukawa > > Acked-by: Yuanhan Liu Applied, thanks