From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] examples/vm_power_manager: fix build with libvirt version < 0.9.3 Date: Mon, 11 Apr 2016 11:26:59 +0200 Message-ID: <1729179.ZFCP7VmEgh@xps13> References: <1460346357-26592-1-git-send-email-yong.liu@intel.com> <1460364631-28381-1-git-send-email-yong.liu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Marvin Liu Return-path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 8BBFF37A8 for ; Mon, 11 Apr 2016 11:27:01 +0200 (CEST) Received: by mail-wm0-f52.google.com with SMTP id f198so137134118wme.0 for ; Mon, 11 Apr 2016 02:27:01 -0700 (PDT) In-Reply-To: <1460364631-28381-1-git-send-email-yong.liu@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-04-11 16:50, Marvin Liu: > Fixes: 2e099bc5d104 ("fix split of compiler and linker options") As commented earlier, I don't think it is the origin of the issue. > +$(info "vm_power_manager required libvirt version >= 0.9.3, please update libvirt-devel first") "required" should be "requires". libvirt-devel is the name of the package on some distributions, but it is not always the case. Moreover, the whole libvirt package must be updated atomically, not only the headers. That's why I think it's better to remove this part and just keep: "vm_power_manager requires libvirt version >= 0.9.3" Other issue: it would better to use $(error to generate a compilation error. But the example should not be skipped from examples/Makefile in this case.