From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH dpdk v2] vfio/ppc64/spapr: Warn if DMA window was created at unexpected offset Date: Tue, 17 Oct 2017 18:13:14 +0200 Message-ID: <1734105.V98Xar4r66@xps> References: <20170426080908.24026-1-aik@ozlabs.ru> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Burakov, Anatoly" , Alexey Kardashevskiy Return-path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 4917B1B824 for ; Tue, 17 Oct 2017 18:13:16 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 28/04/2017 13:19, Burakov, Anatoly: > From: Alexey Kardashevskiy > > VFIO_IOMMU_SPAPR_TCE_CREATE ioctl() returns the actual bus address for > > just created DMA window. It happens to start from zero because the default > > window is removed (leaving no windows) and new window starts from zero. > > However this is not guaranteed and a new window may start from another > > address, this adds a check and an error message. > > > > > > Signed-off-by: Alexey Kardashevskiy > > --- > > Changes: > > v2: > > * this just prints warning and fails instead of incorrectly changing IOVA > > addresses > > --- > > Hi Alexey, > > There are some compile failures with this patch. You'll probably want to replace %lx with PRIx64 or similar :) > > I would argue that just saying "DMA offsets other than zero are not supported" will be sufficient and will make error message less confusing. Up to you though. Please, can we progress on this patch? Is it still a relevant patch? If yes, someone to make a v3, please?