From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v9 07/25] driver: init/uninit common wrappers for PCI drivers Date: Mon, 12 Sep 2016 11:55:05 +0200 Message-ID: <1734475.YWCHRY6Pyt@xps13> References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <1473257297-7221-8-git-send-email-shreyansh.jain@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Shreyansh Jain , hemant.agrawal@nxp.com To: David Marchand Return-path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 8C4245589 for ; Mon, 12 Sep 2016 11:55:07 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id c131so48305710wmh.0 for ; Mon, 12 Sep 2016 02:55:07 -0700 (PDT) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-09-12 09:16, David Marchand: > On Wed, Sep 7, 2016 at 4:07 PM, Shreyansh Jain wrote: > > crypto and ethdev drivers aligned to PCI probe/remove. Existing handlers for > > init/uninit can be easily reused for this. > > I would keep in the commit log a mention on the 1 - 1 association > between the ethdev/crypto device and the pci device. > > Besides, I kind of remember a suggestion to rename init as probe and > uninit as remove (Thomas ?). Yes, here: http://dpdk.org/ml/archives/dev/2016-July/044086.html > But this can go later in the series.