From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 00/18] lib/librte_pmd_fm10k : fm10k pmd driver Date: Mon, 02 Feb 2015 09:19:43 +0100 Message-ID: <17352652.3yiojL8Nvs@xps13> References: <1422594454-11045-1-git-send-email-jing.d.chen@intel.com> <1465014.svDMzIcz90@xps13> <4341B239C0EFF9468EE453F9E9F4604D01661ED1@shsmsx102.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Chen, Jing D" Return-path: In-Reply-To: <4341B239C0EFF9468EE453F9E9F4604D01661ED1-E2R4CRU6q/6iAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2015-02-02 02:59, Chen, Jing D: > Hi, > > From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of Thomas Monjalon > > 2015-01-30 13:46, Jeff Shaw: > > > On Fri, Jan 30, 2015 at 04:26:33PM -0500, Neil Horman wrote: > > > > On Fri, Jan 30, 2015 at 01:07:16PM +0800, Chen Jing D(Mark) wrote: > > > > > From: "Chen Jing D(Mark)" > > > > > Jeff Shaw (18): > > > > > fm10k: add base driver > > [...] > > > > > lib/librte_pmd_fm10k/SHARED/fm10k_api.c | 327 ++++ > > [...] > > > > > > > > Why is there a SHARED directory in the driver? Are there other drivers > > that use > > > > the shared fm10k code? > > > > > > No, the other poll-mode drivers do not use the shared fm10k code. The > > > directory is similar to the 'ixgbe' and 'i40e' directories in their > > > respective PMDs, only that it is named 'SHARED' for the fm10k driver. > > > > So shared is a bad name in the context of DPDK. > > Inside Intel, it can be understood that you share it between projects, > > but in DPDK, it's only a base driver. > > > > OK, I'll change "SHARED" to "fm10k". I think that "base" would be more appropriate: fm10K/base instead of fm10k/fm10k. -- Thomas