From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v4 2/5] ixgbe: enable rx queue interrupts for
	both PF and VF
Date: Mon, 23 Feb 2015 14:20:27 +0100
Message-ID: <1735949.6aPZLmAlBh@xps13>
References: <1424353698-29837-1-git-send-email-danny.zhou@intel.com>
 <4552356.3plUBHddm1@xps13>
 <DFDF335405C17848924A094BC35766CF0AAB3513@SHSMSX104.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: "Zhou, Danny" <danny.zhou-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <DFDF335405C17848924A094BC35766CF0AAB3513-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

2015-02-23 11:23, Zhou, Danny:
> I noticed the V4 patch conflicts with the latest code on the main branch due to lots of code merged, and it 
> is mentioned by Jun Xu in previous email, and I will have to rebase the patch and send out V5 version.

Maybe you misunderstood my comment.
I'm quoting an usage in patch 2 of max_intr which is defined in patch 4.
You have to better split and order your patches to make them compilable
and not break git bisect.

Thanks
 
> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org]
> > Sent: Monday, February 23, 2015 7:20 PM
> > To: Zhou, Danny
> > Cc: dev-VfR2kkLFssw@public.gmane.org
> > Subject: Re: [dpdk-dev] [PATCH v4 2/5] ixgbe: enable rx queue interrupts for both PF and VF
> > 
> > 2015-02-19 21:48, Zhou Danny:
> > > +	/* set max interrupt vfio request */
> > > +	pci_dev->intr_handle.max_intr = hw->mac.max_rx_queues +
> > > +						IXGBE_MAX_OTHER_INTR;
> > > +
> > 
> > Compilation is broken here.