From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] test: test zero socket-mem as valid Date: Sat, 26 Jan 2019 19:20:02 +0100 Message-ID: <1738923.4uAXThKVLp@xps> References: <88e56f1a-f86b-7b19-5f82-28ca31dfea7a@samsung.com> <0937580d-ddbf-f1f2-a6e2-e0d6dad0f33d@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "Burakov, Anatoly" , David Marchand , ShuaiX Zhu , Xueqin Lin , WenjieX A Li , FengqinX Wang , dpdk stable To: Ilya Maximets Return-path: In-Reply-To: <0937580d-ddbf-f1f2-a6e2-e0d6dad0f33d@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/01/2019 15:12, Burakov, Anatoly: > On 25-Jan-19 2:00 PM, Ilya Maximets wrote: > > On 25.01.2019 16:48, Burakov, Anatoly wrote: > >> On 25-Jan-19 9:53 AM, David Marchand wrote: > >>> > >>> Reviewed-by: David Marchand > > >> > >> Now that i think of it, maybe it's not that simple. > >> > >> --socket-mem/-m flag with zero is still an invalid value *if* --legacy-mem is involved. However, it is a valid value in non-legacy mode. > >> > >> So maybe the test should reflect this, and the previous fix should have instead added a check for legacy mode rather than disabling the zero check outright. > >> > > > > I don't think that it's a big deal, because "--socket-mem=0 --legacy-mem" > > quickly fails with clear: > > > > EAL: WARNING: Master core has no memory on local socket! > > > > IMHO, It's actually more informative than previous: > > > > EAL: invalid parameters for --socket-limit > > > > I agree that we could add a test for a legacy-mem cases, but that's a bit > > different task. > > Good point. Maybe leave it as is then :) > > Acked-by: Anatoly Burakov Applied, thanks