From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] virtio: check if devargs is NULL before
	checking its value
Date: Wed, 25 May 2016 12:47:30 +0200
Message-ID: <1740935.53DGeJ2mHm@xps13>
References: <1464100542-48126-1-git-send-email-huawei.xie@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, vincent.mc.li@gmail.com, yuanhan.liu@intel.com
To: Huawei Xie <huawei.xie@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id A78D12BA7
 for <dev@dpdk.org>; Wed, 25 May 2016 12:47:32 +0200 (CEST)
Received: by mail-wm0-f46.google.com with SMTP id z87so57221043wmh.0
 for <dev@dpdk.org>; Wed, 25 May 2016 03:47:32 -0700 (PDT)
In-Reply-To: <1464100542-48126-1-git-send-email-huawei.xie@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> -		    dev->devargs->type != RTE_DEVTYPE_WHITELISTED_PCI) {
> +		    (!dev->devargs ||
> +		     dev->devargs->type != RTE_DEVTYPE_WHITELISTED_PCI)) {

Should the title be something like "fix crash ..."?

I would also add
Reported-by: Vincent Li <vincent.mc.li@gmail.com>