From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v7] app/testpmd: add forwarding mode to
	simulate a noisy neighbour
Date: Tue, 02 Oct 2018 11:51:09 +0200
Message-ID: <1742510.Ad7anXBEc8@xps>
References: <20180921132633.21317-1-jfreimann@redhat.com>
 <5093277.B6gBP5p74m@xps> <20181002085928.gmigdlq7v7wujnyf@jenstp.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: "Iremonger, Bernard" <bernard.iremonger@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>, "ailan@redhat.com" <ailan@redhat.com>,
 "jan.scheurich@ericsson.com" <jan.scheurich@ericsson.com>, "Richardson,
 Bruce" <bruce.richardson@intel.com>,
 "maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>, "Ananyev,
 Konstantin" <konstantin.ananyev@intel.com>, "Yigit,
 Ferruh" <ferruh.yigit@intel.com>, "ktraynor@redhat.com" <ktraynor@redhat.com>
To: Jens Freimann <jfreimann@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 3EC6C200
 for <dev@dpdk.org>; Tue,  2 Oct 2018 11:51:13 +0200 (CEST)
In-Reply-To: <20181002085928.gmigdlq7v7wujnyf@jenstp.localdomain>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

02/10/2018 10:59, Jens Freimann:
> On Tue, Oct 02, 2018 at 09:57:52AM +0200, Thomas Monjalon wrote:
> >02/10/2018 09:19, Jens Freimann:
> >> On Mon, Oct 01, 2018 at 01:13:32PM +0000, Iremonger, Bernard wrote:
> >> >./devtools/check-git-log.sh -1
> >> >Headline too long:
> >> >        app/testpmd: add forwarding mode to simulate a noisy neighbour
> >>
> >> I'm sorry, I failed to use checkpatches.sh correctly :) I did:
> >>
> >> #> git show | DPDK_CHECKPATCH_PATH="/home/jfreiman/code/linux/scripts/checkpatch.pl" devtools/checkpatches.sh --
> >>
> >> 1/1 valid patch
> >
> >Why this command is not correct?
> 
> checkpatches.sh looks for the string "Subject:" which is not included
> in git show output. Using cat on the patch file instead will work. 

Yes indeed.

As an improvement, we could check for "git show" output, starting with "commit" word.