From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3] mem: fix malloc_elem resize with padding Date: Wed, 28 Jun 2017 23:12:41 +0200 Message-ID: <1743355.dtpiII7vli@xps> References: <1496189818-2307-1-git-send-email-lavignen@amazon.com> <1496949137-8106-1-git-send-email-lavignen@amazon.com> <2e4d0d34-626c-0ac2-6c46-c2b1086c3397@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Sergio Gonzalez Monroy To: Jamie Lavigne Return-path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 9C8042BE1 for ; Wed, 28 Jun 2017 23:12:43 +0200 (CEST) In-Reply-To: <2e4d0d34-626c-0ac2-6c46-c2b1086c3397@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/06/2017 12:18, Sergio Gonzalez Monroy: > On 08/06/2017 20:12, Jamie Lavigne wrote: > > Currently when a malloc_elem is split after resizing, any padding > > present in the elem is ignored. This causes the resized elem to be too > > small when padding is present, and user data can overwrite the beginning > > of the following malloc_elem. > > > > Solve this by including the size of the padding when computing where to > > split the malloc_elem. > > > > Fixes: af75078fece3 ("first public release") > > > > Signed-off-by: Jamie Lavigne > > Acked-by: Sergio Gonzalez Monroy Applied, thanks