From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] doc: advise to specify LTS branch when
	backporting patches
Date: Thu, 17 May 2018 15:12:48 +0200
Message-ID: <1744032.J4TBba0YLV@xps>
References: <20180516143134.24838-1-luca.boccassi@gmail.com>
 <7a747fd8-174c-9c10-b9ab-ed0d74555844@redhat.com>
 <1526490189.23337.129.camel@debian.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Kevin Traynor <ktraynor@redhat.com>, dev@dpdk.org, yliu@fridaylinux.org
To: Luca Boccassi <bluca@debian.org>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 477F56CC5
 for <dev@dpdk.org>; Thu, 17 May 2018 15:12:51 +0200 (CEST)
In-Reply-To: <1526490189.23337.129.camel@debian.org>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

16/05/2018 19:03, Luca Boccassi:
> On Wed, 2018-05-16 at 16:19 +0100, Kevin Traynor wrote:
> > On 05/16/2018 03:31 PM, luca.boccassi@gmail.com wrote:
> > > From: Luca Boccassi <bluca@debian.org>
> > > 
> > > We have many stable branches being maintaned at the same time, and
> > 
> > typo
> > 
> > > sometimes it's not clear which branch a patch is being backported
> > > for.
> > > Note in the guidelines that it should be specified via the cover
> > > letter,
> > > annotation or using --subject-prefix.
> > > Also note to send only to stable@dpdk.org, not dev@dpdk.org.
> > > 
> > > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > > ---
> > >  doc/guides/contributing/patches.rst | 8 ++++++++
> > >  1 file changed, 8 insertions(+)
> > > 
> > > diff --git a/doc/guides/contributing/patches.rst
> > > b/doc/guides/contributing/patches.rst
> > > index 2287835f9..1dc623a23 100644
> > > --- a/doc/guides/contributing/patches.rst
> > > +++ b/doc/guides/contributing/patches.rst
> > > @@ -450,6 +450,14 @@ Experienced committers may send patches
> > > directly with ``git send-email`` without
> > >  The options ``--annotate`` and ``confirm = always`` are
> > > recommended for checking patches before sending.
> > >  
> > >  
> > > +Backporting patches for Stable Releases
> > > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > > +
> > > +Sometimes a maintainer or contributor wishes, or can be asked, to
> > > send a patch for a stable release rather than mainline. In this
> > > case the patch(es) should be sent to ``stable@dpdk.org``, not to ``
> > > dev@dpdk.org``.
> > > +
> > > +Given that there are multiple stable releases being maintained at
> > > the same time, please specify exactly which branch the patch is for
> > > in the cover letter, in the annotation or using ``git send-email --
> > > subject-prefix='16.11' ...``
> > > +
> > 
> > s/branch/branch(es)/
> > 
> > How about [16.11] instead of '16.11' ?
> 
> Using --subject-prefix git will already use "[PATCH 16.11]

I think it should be --subject-prefix='PATCH 16.11'

Please wrap the lines after some punctuation signs to avoid really long lines
in the rst file.