From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [dpdk-stable] [PATCH] dev: fix dev_attach proceeding with vdev on success Date: Mon, 31 Jul 2017 09:46:39 +0200 Message-ID: <1745224.TJoYg1OxSO@xps> References: <3505500ec4b4a452528da1eb2076e11bdc22068c.1501069907.git.gaetan.rivet@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: stable@dpdk.org, dev@dpdk.org, Jan Blunck To: Gaetan Rivet Return-path: In-Reply-To: <3505500ec4b4a452528da1eb2076e11bdc22068c.1501069907.git.gaetan.rivet@6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 26/07/2017 13:52, Gaetan Rivet: > When rte_eal_hotplug_add() successfully probe a device, the return value > is zero. The check afterward only returns on error different from > -EINVAL. It should return also on success, as there is no need to > attempt probing the device with vdev. > > Fixes: 0bba9e605048 ("eal: use new hotplug API in attach") > Cc: stable@dpdk.org > Cc: Jan Blunck > > Signed-off-by: Gaetan Rivet Applied, thanks