From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 0/5] add device removal event Date: Fri, 21 Apr 2017 00:45:13 +0200 Message-ID: <1745480.obotDYhibW@xps> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Jingjing Wu , Adrien Mazarguil , Nelio Laranjeiro To: Gaetan Rivet Return-path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 37D972904 for ; Fri, 21 Apr 2017 00:45:15 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 18/04/2017 14:17, Gaetan Rivet: > This new event represents the sudden removal of a device from its bus. > The underlying resources exposed by the bus are expected not to be available > anymore. The application should thus be able to react and possibly clean up > related resources that it reserved for the removed device. > > This event is different from the current hotplug API available in the DPDK > for two reasons: > > 1. It is a reactive design: the application reacts to a device that has been > removed instead of removing a device from its pool. > > 2. The event itself is going further than the current detaching of a device > from a DPDK application. If the bus is a hardware one, it is expected of > the underlying resources to not be available anymore. > > This series adds a new event type to ethdev and implements it in mlx4. > Testpmd is also updated to report all asynchronous ethdev events including > this one for testing purposes and as a practical usage example. > > This series depends on the series titled > [PATCH 1/2] net/mlx4: split the definitions to the header file > > v1 --> v2: > * integrated the series with the new PCI rte_bus implementation. > > I planned on working out a more generic implementation of the RMV event > for the v17.05, however while writing it I found that I had to evolve the > support of interrupts in the PCI rte_bus, which did not seem wise at this > point of the release cycle. > > I consider that this event should be generalized along the LSC event, > going from pure PCI events to generic rte_bus events, given that they can > be relevant to other busses (vdev at least). I would reserve this evolution > for future release however, once a real discussion has taken place. > > Gaetan Rivet (5): > ethdev: introduce device removal event > net/mlx4: device removal event support > app/testpmd: generic event handler > app/testpmd: request link status interrupt > app/testpmd: request device removal interrupt Applied, thanks