From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3] mk: fix compile error and ABI versioning for combined shared library Date: Thu, 03 Dec 2015 03:22:39 +0100 Message-ID: <17459798.JpEqoIGKUu@xps13> References: <20151203015919.GA23772@sivlogin002.ir.intel.com> <1449108909-29421-1-git-send-email-ferruh.yigit@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Ferruh Yigit Return-path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 15F59568A for ; Thu, 3 Dec 2015 03:23:50 +0100 (CET) Received: by wmww144 with SMTP id w144so3150963wmw.1 for ; Wed, 02 Dec 2015 18:23:50 -0800 (PST) In-Reply-To: <1449108909-29421-1-git-send-email-ferruh.yigit@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-12-03 02:15, Ferruh Yigit: > +ifeq ($(COMBINED_BUILD),1) > include $(RTE_SDK)/mk/rte.sharelib.mk > +endif I still don't understand what was the issue with this include but it seems not related to versioning. Please condider a separate patch with a detailed explanation of the bug. [...] > +FILES=$(find $RTE_SDK -name "*_version.map") No, we can have several build directories in RTE_SDK.