From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH 1/3] hash: run-time function selection
Date: Sat, 20 Jan 2018 15:36:10 +0100
Message-ID: <1746855.zJqQpDPaSL@xps>
References: <1509991442-26391-1-git-send-email-elza.mathew@intel.com>
 <20171211125210.GA15784@bricha3-MOBL3.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
 pablo.de.lara.guarch@intel.com
To: Elza Mathew <elza.mathew@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id C2427A49C
 for <dev@dpdk.org>; Sat, 20 Jan 2018 15:36:46 +0100 (CET)
In-Reply-To: <20171211125210.GA15784@bricha3-MOBL3.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

11/12/2017 13:52, Bruce Richardson:
> On Mon, Nov 06, 2017 at 10:04:02AM -0800, Elza Mathew wrote:
> > Compile-time function selection can potentially lead to
> > lower performance on generic builds done by distros.
> > Replaced compile time flag checks with run-time function
> > selection.
> > 
> > Signed-off-by: Elza Mathew <elza.mathew@intel.com>
> > ---
> >  lib/librte_hash/rte_cuckoo_hash.c | 10 +++++++++-
> >  lib/librte_hash/rte_cuckoo_hash.h |  6 ------
> >  2 files changed, 9 insertions(+), 7 deletions(-)
> > 
> 
> Looks good to me.
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks