From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2] kni: fix build for Linux kernel 4.19
Date: Fri, 26 Oct 2018 15:29:00 +0200
Message-ID: <1748383.aenPN5C8uf@xps>
References: <20181024105443.57063-1-ferruh.yigit@intel.com>
 <20181024111010.15568-1-ferruh.yigit@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, stephen@networkplumber.org
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id CF754FEB
 for <dev@dpdk.org>; Fri, 26 Oct 2018 15:28:57 +0200 (CEST)
In-Reply-To: <20181024111010.15568-1-ferruh.yigit@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

24/10/2018 13:10, Ferruh Yigit:
> The build error observed with Linux kernel 4.19 when KNI ethtool
> support enabled (CONFIG_RTE_KNI_KMOD_ETHTOOL=3Dy)
>=20
> .../build/build/kernel/linux/kni/kni_ethtool.c:193:3:
>    error: =E2=80=98struct ethtool_ops=E2=80=99 has no member named =E2=80=
=98get_settings=E2=80=99;
>   .get_settings  =3D kni_get_settings,
>    ^~~~~~~~~~~~
>=20
> .../build/build/kernel/linux/kni/kni_ethtool.c:194:3:
>    error: =E2=80=98struct ethtool_ops=E2=80=99 has no member named =E2=80=
=98set_settings=E2=80=99;
>   .set_settings  =3D kni_set_settings,
>    ^~~~~~~~~~~~
>=20
> With kernel 4.19 ethtool_ops `get_settings` & `set_settings` are
> replaced with `get_link_ksettings` & `set_link_ksettings`
> Commit 9b3004953503 ("ethtool: drop get_settings and set_settings callbac=
ks")
>=20
> This fix practically removes `get_settings` & `set_settings` support
> for the kernel versions that have the new ethtool_ops without
> implementing the new ones.
>=20
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks