From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] mk: add makefile extention support Date: Mon, 29 Feb 2016 09:21:50 +0100 Message-ID: <1751683.N1tvm7xWVW@xps13> References: <1455039314-86891-1-git-send-email-keith.wiles@intel.com> <1976319.EWLy02CyDg@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org To: "Wiles, Keith" Return-path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 94A4C6A6F for ; Mon, 29 Feb 2016 09:23:25 +0100 (CET) Received: by mail-wm0-f49.google.com with SMTP id p65so57378286wmp.1 for ; Mon, 29 Feb 2016 00:23:25 -0800 (PST) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-02-28 21:47, Wiles, Keith: > >Hi, > > > >2016-02-09 11:35, Keith Wiles: > >> Adding support to the build system to allow for Makefile.XXX > >> extention to a subtree, which already has Makefiles. These > >> Makefiles could be from the autotools and others places. Using > >> the Makefile extention RTE_MKFILE_SUFFIX in a makefile subtree > >> using 'export RTE_MKFILE_SUFFIX=3D.XXX' to use Makefile.XXX in > >> that subtree. > >>=20 > >> The main reason I needed this feature was to integrate a autotool > >> open source projects with DPDK and keep the original Makefiles. > > > >Sorry I fail to understand why it is needed. > >Are you trying to add autotool in DPDK? I don't think it is a good a= pproach. > >The DPDK must provide a pkgconfig interface to be integrated anywher= e. >=20 > I was not trying to add autotools to DPDK. On a number of times I wan= ted to integrate a open source project(s) with DPDK and use DPDK=E2=80=99= s build system, but because the open source project already contained M= akefile files you can not use DPDK build system without modify or movin= g the original Makefile files. Using this method I can just add a expor= ted variable and supply my own Makefile.XXX files. >=20 > One case was building FreeBSD source, but I did not want to modify Fr= eeBSD Makefiles (or reply on previous built Makefiles as they would not= work on Linux anyway) as I was pulling the source down from freebsd.or= g repo. Using a patch to add the Makefiles with a different suffix allo= ws me to build FreeBSD using DPDK, without having to modify or own the = FreeBSD source. I have had this problem a number of times with open sou= rce code I did not want to modify, but just build within DPDK build sys= tem and adding the support for a different suffix to DPDK provided a cl= ean way. The change does not effect the correct build system and just a= llows someone to define a new suffix for a given subtree in the code. Why would you like to have another project inside the DPDK files tree? If you want to integrate the lib inside an existing project, the soluti= on is pkgconfig.