From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] net/i40e: add a specific API to control the
	LLDP agent
Date: Mon, 21 May 2018 10:39:41 +0200
Message-ID: <1752366.FEJfUWy9xN@xps>
References: <1526638447-31246-1-git-send-email-zijie.pan@6wind.com>
 <3140133.83vjVej6t9@xps> <tencent_25F9DE79387EB3480E65FF66@qq.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Laurent Hardy <laurent.hardy@6wind.com>, dev <dev@dpdk.org>,
 "beilei.xing" <beilei.xing@intel.com>, "qi.z.zhang" <qi.z.zhang@intel.com>,
 "helin.zhang" <helin.zhang@intel.com>
To: Zijie Pan <zijie.pan@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 529149605
 for <dev@dpdk.org>; Mon, 21 May 2018 10:39:44 +0200 (CEST)
In-Reply-To: <tencent_25F9DE79387EB3480E65FF66@qq.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

21/05/2018 05:35, Zijie Pan:
> > > Add a new API rte_pmd_i40e_set_lldp_cmd to control LLDP agent for i40e.
> > > It supports the following i40e debug lldp commands:
> > >     - start/stop of the LLDP agent.
> > >     - get local/remote of the LLDP MIB (Management Information Base).
> > >
> > > Signed-off-by: Laurent Hardy <laurent.hardy@6wind.com>
> > > Signed-off-by: Zijie Pan <zijie.pan@6wind.com>
> >
> > Does it mean that this feature is enabled by default in i40e devices?
> > Should it be disabled by default?
> 
> The new API is just an interface to control the LLDP agent. No functions of i40e call it by default. It is only used to debug LLDP of i40e devices. For example we can add a new command for test-pmd to debug lldp of i40e by calling rte_pmd_i40e_set_lldp_cmd().

There is a command to stop the LLDP agent.
My question is to know whether this agent is running by default
and should be disabled?
I mean i40e is generating LLDP packets by default?