From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] eal: fix NULL device argument pointer
	reference
Date: Mon, 22 Oct 2018 09:30:12 +0200
Message-ID: <1754125.JGkyPi735h@xps>
References: <20181022061516.45912-1-qi.z.zhang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Qi Zhang <qi.z.zhang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id B036A4C99
 for <dev@dpdk.org>; Mon, 22 Oct 2018 09:30:12 +0200 (CEST)
In-Reply-To: <20181022061516.45912-1-qi.z.zhang@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

22/10/2018 08:15, Qi Zhang:
> dev->devargs is not initialized for PCI device, so use dev->bus to
> replace dev->devargs->bus to avoid segment fault when hotplug remove
> a PCI device.

It is not really specific to PCI device.
The devargs is not initialized if the device is probed by default policy
(i.e. not in blacklist).

I think we can say that "devargs is not always initialized".

> Fixes: 244d5130719c ("eal: enable hotplug on multi-process")
> 
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>