From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v3] kni: fix compilation issue in KNI vhost
	on kernel 3.19/4.0
Date: Mon, 11 May 2015 10:27:40 +0200
Message-ID: <1757105.2rpKOWrz79@xps13>
References: <1430829319-22242-1-git-send-email-pablo.de.lara.guarch@intel.com>
 <8281433.nBqoHGD3WT@xps13>
 <E115CCD9D858EF4F90C690B0DCB4D897272A5290@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52])
 by dpdk.org (Postfix) with ESMTP id DFDE4C3D2
 for <dev@dpdk.org>; Mon, 11 May 2015 10:28:22 +0200 (CEST)
Received: by wgiu9 with SMTP id u9so120754051wgi.3
 for <dev@dpdk.org>; Mon, 11 May 2015 01:28:21 -0700 (PDT)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D897272A5290@IRSMSX108.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-05-10 23:01, De Lara Guarch, Pablo:
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > I have the following errors with Linux 4.0.1:
> >=20
> > lib/librte_eal/linuxapp/kni/igb_main.c:2321:2: error: initializatio=
n from
> > incompatible pointer type
> >   .ndo_bridge_setlink =3D igb_ndo_bridge_setlink,
> >   ^
> > lib/librte_eal/linuxapp/kni/igb_main.c:2321:2: error: (near initial=
ization for
> > =E2=80=98igb_netdev_ops.ndo_bridge_setlink=E2=80=99)
> > lib/librte_eal/linuxapp/kni/igb_main.c: In function =E2=80=98igb_xm=
it_frame_ring=E2=80=99:
> > lib/librte_eal/linuxapp/kni/igb_main.c:5482:2: error: implicit decl=
aration of
> > function =E2=80=98vlan_tx_tag_present=E2=80=99
> >   if (vlan_tx_tag_present(skb)) {
> >   ^
> > lib/librte_eal/linuxapp/kni/igb_main.c:5484:3: error: implicit decl=
aration of
> > function =E2=80=98vlan_tx_tag_get=E2=80=99
> >    tx_flags |=3D (vlan_tx_tag_get(skb) << IGB_TX_FLAGS_VLAN_SHIFT);=

> >    ^
>=20
> I sent a patch for that (kni: fix compilation issue on kernel 4.0.0),=
 by the end of last month.

Oh yes, you're right, sorry.

> Is it OK to merge it or do you want me to send a v4 of this one, incl=
uding that fix?

Separate patches are OK, thanks.