From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 3/3] app/test: enable test_red to build on non x86 platform Date: Tue, 25 Aug 2015 14:03:13 +0200 Message-ID: <1759749.jiktJN44xV@xps13> References: <1439901605-31164-1-git-send-email-jerin.jacob@caviumnetworks.com> <1439901605-31164-3-git-send-email-jerin.jacob@caviumnetworks.com> <1439901605-31164-4-git-send-email-jerin.jacob@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit To: dev@dpdk.org, Jerin Jacob Return-path: Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com [209.85.212.169]) by dpdk.org (Postfix) with ESMTP id 8BD9A5A35 for ; Tue, 25 Aug 2015 14:04:24 +0200 (CEST) Received: by widdq5 with SMTP id dq5so12868022wid.0 for ; Tue, 25 Aug 2015 05:04:24 -0700 (PDT) In-Reply-To: <1439901605-31164-4-git-send-email-jerin.jacob@caviumnetworks.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-08-18 18:10, Jerin Jacob: > --- a/app/test/test_red.c > +++ b/app/test/test_red.c > +#if defined(RTE_ARCH_X86_64) || defined(RTE_ARCH_I686) || defined(RTE_ARCH_X86_X32) > #ifdef __PIC__ > asm volatile ( > "mov %%ebx, %%edi\n" > @@ -155,6 +156,7 @@ static inline void rdtsc_prof_start(struct rdtsc_prof *p) > #else > asm( "cpuid" : : : "%eax", "%ebx", "%ecx", "%edx" ); > #endif > +#endif > p->clk_start = rte_rdtsc(); The right fix would be to move that arch-specific code into an EAL abstraction.