From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v6 3/7] eventdev: add eth Rx adapter caps function to SW PMD Date: Wed, 11 Oct 2017 01:16:25 +0200 Message-ID: <1760785.loeYggim5W@xps> References: <1507674097-19597-1-git-send-email-nikhil.rao@intel.com> <1507674097-19597-4-git-send-email-nikhil.rao@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com To: Nikhil Rao Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id EA25B1B2A4 for ; Wed, 11 Oct 2017 01:16:29 +0200 (CEST) In-Reply-To: <1507674097-19597-4-git-send-email-nikhil.rao@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, 11/10/2017 00:21, Nikhil Rao: > --- a/lib/librte_eventdev/rte_eventdev_pmd.h > +++ b/lib/librte_eventdev/rte_eventdev_pmd.h > @@ -83,6 +83,14 @@ extern "C" { > } \ > } while (0) > > +#define RTE_EVENT_ETH_RX_ADAPTER_SW_CAP \ > + ((RTE_EVENT_ETH_RX_ADAPTER_CAP_OVERRIDE_FLOW_ID) | \ > + (RTE_EVENT_ETH_RX_ADAPTER_CAP_MULTI_EVENTQ)) > + > +/**< Ethernet Rx adapter cap to return If the packet transfers from > + * the ethdev to eventdev use a SW service function > + */ It is a value specific to the SW driver. I think it should not be defined in librte_eventdev. Do you mind to move it for RC2?