From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [RFC 1/3] test/meson: auto detect number of cores Date: Mon, 01 Apr 2019 21:39:58 +0200 Message-ID: <1762513.D2pieINcJM@xps> References: <20190329172241.11916-1-aconole@redhat.com> <3AEA2BF9852C6F48A459DA490692831F2A433A0F@irsmsx110.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: "Pattan, Reshma" , "dev@dpdk.org" , "Babu Radhakrishnan, AgalyaX" , "Parthasarathy, JananeeX M" , David Marchand To: Aaron Conole Return-path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 318403572 for ; Mon, 1 Apr 2019 21:40:07 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 01/04/2019 19:48, Aaron Conole: > "Pattan, Reshma" writes: > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Aaron Conole > >> > >> Some environments do not provide a minimum 4 cores for running tests. This > >> allows those environments to still execute 'ninja test' without causing multiple > >> failures. > >> > > > > FYI, there is a patch http://patches.dpdk.org/patch/50850/ doing something similar. > > > > --file-prefix is not supported on FreeBSD, so how about you also > > include the related fix from above patch link into your patch series? > > Is that other patch going to be accepted? Then I can drop this patch > from my series. Otherwise, I'll fold in such a change with my next > version. Sorry, I'm late on applying patches for unit tests. As I am not sure which one will get the best review first, you should keep it with a note that it conflicts with the other one.