From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] lib: fix RTE_MBUF_METADATA macros Date: Mon, 22 Jun 2015 22:42:46 +0200 Message-ID: <1763224.PSL4DjGVg9@xps13> References: <1433516110-11468-1-git-send-email-danielx.t.mrzyglod@intel.com> <29909138.qD9kMyzFYN@xps13> <20150622132319.258a5ba3@cchemparathy-ubuntu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Cyril Chemparathy Return-path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id 77670C7BC for ; Mon, 22 Jun 2015 22:43:48 +0200 (CEST) Received: by wibdq8 with SMTP id dq8so86766852wib.1 for ; Mon, 22 Jun 2015 13:43:48 -0700 (PDT) In-Reply-To: <20150622132319.258a5ba3@cchemparathy-ubuntu> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-06-22 13:23, Cyril Chemparathy: > On Mon, 22 Jun 2015 22:16:59 +0200 > Thomas Monjalon wrote: > > Cyril, feel free to fix it if it breaks with Tile arch. > > Why define these locally within rte_port.h? Shouldn't these macros > really be in rte_mbuf.h? No, an application is free to put its metadata elsewhere. The packet framework (port/table/pipeline) did the choice to put some metadata here but there is no need to enforce it for everybody.