From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH 2/7] mem: use proper prefix
Date: Thu, 01 Nov 2018 15:50:59 +0100
Message-ID: <1764123.29vNcfR2yM@xps>
References: <20181031172931.11894-1-alejandro.lucero@netronome.com>
 <20181031172931.11894-3-alejandro.lucero@netronome.com>
 <68244b83-2810-043e-f9b5-0b8984e99ab9@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>,
 Alejandro Lucero <alejandro.lucero@netronome.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id BA3174D3A
 for <dev@dpdk.org>; Thu,  1 Nov 2018 15:51:01 +0100 (CET)
In-Reply-To: <68244b83-2810-043e-f9b5-0b8984e99ab9@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

01/11/2018 11:08, Burakov, Anatoly:
> On 31-Oct-18 5:29 PM, Alejandro Lucero wrote:
> > Current name rte_eal_check_dma_mask does not follow the naming
> > used in the rest of the file.
> > 
> > Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
> > ---
> 
> I don't think this belongs in the _mem_ namespace. It is usually used 
> for things to do with memory, while the DMA mask IMO sits firmly in the 
> domain of EAL, specifically bus subsystem.

It is a memory allocation check, isn't it?

I think rte_mem_ prefix is more meaningful.
Anyway, we should avoid rte_eal which is too vague.
For device management, we use rte_bus, rte_dev, etc.

> However, i don't have strong feelings one way or the other, so if you do 
> decide to go forward with this naming...