From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [RFC PATCH 2/3] ethdev: advertise default MAC as
	retained on device restart
Date: Wed, 10 Oct 2018 11:35:28 +0200
Message-ID: <1764273.HaIcP3AaDl@xps>
References: <1539157900-6208-1-git-send-email-arybchenko@solarflare.com>
 <9285291.oQvEkmlzME@xps>
 <6dbbefd9-1677-1233-0f7d-0988410b7157@solarflare.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, ferruh.yigit@intel.com
To: Andrew Rybchenko <arybchenko@solarflare.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 071FF1B485
 for <dev@dpdk.org>; Wed, 10 Oct 2018 11:35:32 +0200 (CEST)
In-Reply-To: <6dbbefd9-1677-1233-0f7d-0988410b7157@solarflare.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

10/10/2018 11:05, Andrew Rybchenko:
> On 10/10/18 11:53 AM, Thomas Monjalon wrote:
> > 10/10/2018 09:51, Andrew Rybchenko:
> >> The documentation says MAC addresses array is retained and
> >> it is logical to assume that default MAC address is retained
> >> as well.
> > I'm confused. Default MAC address isn't implied by MAC addresses array?
> 
>  From API point of view it looks as different features (at least for me):
>   - default MAC address is rte_eth_dev_default_mac_addr_set()
>   - MAC addresses array is 
> rte_eth_dev_mac_addr_add()/rte_eth_dev_mac_addr_remove()
> but it is under one umbrella in NIC features (Unicast MAC filter).

Because default MAC address is mac_addrs[0].

> May be it is my misunderstanding.

More doc is better :)
If it can be thought as different features, let's document it as you do.