From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [EXT] [PATCH] config: change default cache line size
	for ARMv8 with meson
Date: Wed, 09 Jan 2019 12:28:20 +0100
Message-ID: <1764937.rquPbBeTJo@xps>
References: <20190109093915.40882-1-yskoh@mellanox.com>
 <0F6E5E54-EC4A-42AD-AF67-D901802F24E3@mellanox.com>
 <15db28a8a28845f20ab9f5da1782f3c62fc7db80.camel@marvell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: "shahafs@mellanox.com" <shahafs@mellanox.com>,
 "Gavin.Hu@arm.com" <Gavin.Hu@arm.com>, "bluca@debian.org" <bluca@debian.org>,
 "dev@dpdk.org" <dev@dpdk.org>, honnappa.nagarahalli@arm.com,
 Thomas Speier <tspeier@qti.qualcomm.com>
To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
 "yskoh@mellanox.com" <yskoh@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 9B01B1B416
 for <dev@dpdk.org>; Wed,  9 Jan 2019 12:28:23 +0100 (CET)
In-Reply-To: <15db28a8a28845f20ab9f5da1782f3c62fc7db80.camel@marvell.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

09/01/2019 11:49, Jerin Jacob Kollanukkaran:
> On Wed, 2019-01-09 at 10:22 +0000, Yongseok Koh wrote:
> > On Jan 9, 2019, at 2:09 AM, Jerin Jacob Kollanukkaran wrote:
> > > I think, I way forward is to add config/arm/arm64_a72_linuxapp_gcc
> > > for meson. This config can be used for all SoC with A72 armv8 
> > > implementation and may have sym link to specfific SoC to avoid
> > > confusion to end users.
> > 
> > Is config/arm/arm64_a72_linuxapp_gcc valid? Others have 
> 
> Yes. For cross compiling for A72.

Any cross-compilation with meson requires a config file.
The default Arm cross-compilation is done with
	config/arm/arm64_armv8_linuxapp_gcc
which set implementor_id = 'generic'

For native compilation, implementor_id is detected from
/sys/devices/system/cpu/cpu0/regs/identification/midr_el1

So each Arm machine needs 2 things:
	- a cross-compilation file
	- settings based on implementor_id in config/arm/meson.build

> Having not seperate IMPLEMENTOR ID is a chip design issue.

No I don't think it's a design issue.
If the Arm core has no modification, it does not need to be
specially identified.

> I think it can work around by creating
> config/arm/arm64_<your_soc_name>_linuxapp_gcc
> and build on x86 or arm64 through
> 
> meson build --cross-file config/arm/arm64_<your_soc_name>_linuxapp_gcc

No, it is a real A72, so it should work with default settings.

The only issue we have is that the default cache line size for Aarch64
is set to 128 in config/arm/meson.build, and this is wrong.
The default cache line is 64 bits.
This is already overriden for Cavium machines which have 128-bit cache lines.
It may be needed to do the same change for other machines (Qualcomm?)
having Arm core modified to 128-bit cache lines.

The other concern is about running a generic Arm build.
Given 64-bit should be the default, generic builds will have this value.
Is it a big issue for running generic 64-bit build on Cavium machines?