From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] app/testpmd: fix build without ixgbe Date: Fri, 16 Jun 2017 16:09:04 +0200 Message-ID: <1764991.rUGqORsVcK@xps> References: <20170615095446.2187-1-thomas@monjalon.net> <6A0DE07E22DDAD4C9103DF62FEBC09093B5CF493@shsmsx102.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Lu, Wenzhuo" , "Nicolau, Radu" Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 8E1262BD1 for ; Fri, 16 Jun 2017 16:09:06 +0200 (CEST) In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B5CF493@shsmsx102.ccr.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/06/2017 03:29, Lu, Wenzhuo: > From: Nicolau, Radu > > > > Looks ok to me, but why would one enable IXGBE_BYPASS without enabling > > IXGBE? > > Although the scenario doesn't make sense, I think it's better to add more check to avoid the users making any mistake. Applied