From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] check-experimental-syms.sh: prevent symbol
	matches on substrings
Date: Wed, 10 Oct 2018 16:43:14 +0200
Message-ID: <1766289.2YrT9N83Jn@xps>
References: <20181010142928.11274-1-nhorman@tuxdriver.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>
To: Neil Horman <nhorman@tuxdriver.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id CA9EF1B6C7
 for <dev@dpdk.org>; Wed, 10 Oct 2018 16:43:17 +0200 (CEST)
In-Reply-To: <20181010142928.11274-1-nhorman@tuxdriver.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

10/10/2018 16:29, Neil Horman:
> Thomas attempted to submit this:
> https://patches.dpdk.org/patch/46311/
> 
> The other day, because the other patches being submitted with it were
> breaking on a false positive from the check-experimental-syms check.
> 
> The problem was that the experimental symbol check script matched on the
> regexs "\.text.*$SYM" and "\.text\.experimental.*$SYM" which allows for
> substring matches, and librte_ethdev recently introduced symbols that
> are leading substrings of one another (e.g. symbol foo is a substring of
> symbol foobar), and so we would match on symbols when we shouldn't
> 
> Instead of dropping the check, fix this properly by matching
> additionally on the end of line so that symbols are an exact match.
> 
> Confirmed to build properly on Thomas' submitted patch set with the
> experimental check patch reverted (so that the checking actually
> happens)

That's great Neil!
I would like to push it now.
May I suggest to remove the details of how I (baldly) reported it?

I suggest this text:
"
The experimental symbol check script matched on the regexes
"\.text.*$SYM" and "\.text\.experimental.*$SYM" which allows for
substring matches.
If a symbol is leading substring of another one (e.g. symbol foo
is a substring of symbol foobar), it would match on symbols
when it shouldn't.

It is fixed by matching additionally on the end of line
so that symbols are an exact match.
"