From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [dpdk-stable] [PATCH] app/testpmd: fix forward port ids setting Date: Wed, 06 Sep 2017 12:21:18 +0200 Message-ID: <1766803.K7SpHi0fzz@xps> References: <1504444747-56298-1-git-send-email-matan@mellanox.com> <20170904095231.GD21444@bidouze.vm.6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: Jingjing Wu , dev@dpdk.org, Ori Kam To: =?ISO-8859-1?Q?Ga=EBtan?= Rivet , Matan Azrad Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 403E3FE5 for ; Wed, 6 Sep 2017 12:21:20 +0200 (CEST) In-Reply-To: <20170904095231.GD21444@bidouze.vm.6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 04/09/2017 11:52, Ga=EBtan Rivet: > On Mon, Sep 04, 2017 at 09:25:04AM +0000, Matan Azrad wrote: > > From: Ga=EBtan Rivet [mailto:gaetan.rivet@6wind.com] > > > On Sun, Sep 03, 2017 at 04:19:07PM +0300, Matan Azrad wrote: > > > > Hi All > > > > I would like to bring up a discussion to complete this bug fix. > > > > > > > > When user wants to set the list of forwarding ports by "set portlis= t" > > > > (testpmd command line), the testpmd application checks the > > > > availability of the ports by rte_eth_dev_is_valid_port API. > > > > By this way, it gets the DEFERRED port as valid port and will try to > > > > recieve\send packets via this port. > > > > > > > > This scenario will cause the same error as this patch fixes. > > > > > > > > Should testpmd allow user to run traffic by DEFERRED port directly? > > > > > > > > If any application wants to check a port availability for device us= age > > > > (conf\rxtx), Which API should be used? > > > > > > > > According to the patch cb894d99eceb ("ethdev: add deferred > > > > intermediate device state"), DEFERRED ports should be invisible to > > > > application, So maybe the rte_eth_dev_is_valid_port API should be > > > > internal and a new ethdev API should be created for applications. > > > > > > > > What do you think? > > > > > > >=20 > > > I think that regardless of the semantic of the DEFERRED state or any = other > > > port handling, the correct assumption is to consider any port iterate= d over by > > > RTE_ETH_FOREACH_DEV to be the exact set of devices that are supposed = to > > > be usable. In the event of an API evolution regarding port states, th= is macro > > > should remain correct. > > >=20 > > > So I think your fix is correct, and that the implication of > > > RTE_ETH_FOREACH_DEV avoiding DEFERRED devices is correct. > > >=20 > >=20 > > This patch fixes the default forward ports setting (actually when user = don't use --portmask param or "set portlist"), > > But it don't fix the port validation which PMD does for "set portlist" = command. > > So, the discussion is how to fix this port validation. >=20 > You could make a static rte_eth_dev_is_valid_port with a different name, > declare both RTE_ETH_VALID_PORT* macros within rte_ethdev.c > and introduce a new rte_eth_dev_is_valid_port which would restrict > devices to those ATTACHED. >=20 > I'm not sure this would be interesting for applications. Currently this > check is performed internally by the ether layer, I guess most > applications rely on it. Making the "extended" version (ATTACHED + > DEFERRED) private with the strict one public would probably not change > behaviors, thus it would probably have little to no effect. >=20 > So my opinion is "why not, but the risk is adding dead code for no real > benefit". >=20 > > In current code, testpmd uses rte_eth_dev_is_valid_port which return t= he DEFERRED device too for forwarding. > > Should it use the RTE_ETH_FOREACH_DEV iterator for one port validation= ?=20 > > Don't you think we need new API for one port? Please, let's continue this ethdev discussion in a separate thread. I've started a new one: http://dpdk.org/ml/archives/dev/2017-September/074656.html