From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 03/10] mk: install a standard cutomizable tree Date: Wed, 02 Dec 2015 14:05:29 +0100 Message-ID: <1767798.Go7fG5LFJB@xps13> References: <1449028676-19232-1-git-send-email-thomas.monjalon@6wind.com> <1789607.LxQySkSOJm@xps13> <565EEA08.9050900@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Panu Matilainen Return-path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 9F63C5913 for ; Wed, 2 Dec 2015 14:06:38 +0100 (CET) Received: by wmww144 with SMTP id w144so56016758wmw.0 for ; Wed, 02 Dec 2015 05:06:38 -0800 (PST) In-Reply-To: <565EEA08.9050900@redhat.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-12-02 14:54, Panu Matilainen: > On 12/02/2015 01:25 PM, Thomas Monjalon wrote: > > 2015-12-02 12:27, Panu Matilainen: > >> $(prefix)/share is supposed to be shareable across different > >> architectures. Most of the content here is, but at least the lib symlink > >> and .config file are not. > > > > The case you want to address is multilib 32/x32/64, right? > > That, plus modern Debian/Ubuntu supports multiarch, not just -lib. We do not support completely different platforms (e.g. ARM and x86) with only one include directory. At the moment, only variants (32/64) live together. > >> One option is to install .config and the symlinks within $(sdkdir)/$(T) > >> directories, then it can be shared across architectures because each > >> lives in their own directory. Another possibility is moving the whole > >> sdk directory into a subdir in $(libdir), but that misses the > >> opportunity to share across architectures (whether anybody actually > >> cares is a whole other question :) > > > > Yes, I tried to remove the use of RTE_TARGET when building an example. > > But we can keep it with a subdirectory in $(sdkdir). > > Just realized my suggestion $(sdkdir)/$(T) would not cut it because if > T= is specified then this installation method wont be invoked at all :D I don't understand what you mean. In my patchset, the installation is the same (except some default values) with and without T=. > So yeah, RTE_TARGET. Or perhaps just RTE_ARCH. Dunno if there's actual > added value to having the whole target string there, but I wont mind either. RTE_TARGET is a safe choice for future.