From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v5] eal: map uio resources after hugepages when the base_virtaddr is configured. Date: Thu, 06 Nov 2014 16:58:05 +0100 Message-ID: <176911891.PG8FvFrDef@xps13> References: <1415193919-17361-1-git-send-email-liang.xu@cinfotech.cn> <1415287928-14513-1-git-send-email-liang.xu@cinfotech.cn> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Burakov, Anatoly" Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-11-06 15:41, Burakov, Anatoly: > Thomas, do we need to do similar changes to VFIO code, to keep consistency? > Also, do we really need for this to depend on --base-virtaddr? Why not do it > unconditionally, i.e. map PCI resources right after hugepages in memory? I don't really like the secondary process mechanism at all. So I won't give good advice here ;) But I feel this option --base-virtaddr should be improved or removed. -- Thomas