From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] examples: fix symmetric_mp,
	set NIC rx_drop_en bit
Date: Thu, 04 Dec 2014 14:37:15 +0100
Message-ID: <1770523.OPzYA99vBi@xps13>
References: <1417625819-3024-1-git-send-email-bruce.richardson@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Bruce Richardson <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <1417625819-3024-1-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

2014-12-03 16:56, Bruce Richardson:
> The symmetric_mp example app is set up to allow two processes to
> share a NIC port, with each pulling packets from one queue. In order
> to have the app continue working when one of the process dies, the
> drop_en bit should be set in the NIC configuration. Without this bit
> set, the NIC will stall once any queue fills. With the bit set, once
> a queue fills, all subsequent packets for that queue are discarded
> allowing other queues to continue operating as normal.
> 
> This setting was missed when converting to use standardised defaults
> in commit 81f7ecd9.

I don't see rx_drop_en in commit 81f7ecd9.
Why do you say it was missed?

-- 
Thomas